8340547: Starting many threads can delay safepoints #1365
Conversation
|
👋 Welcome back snazarki! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
openjdk
bot
changed the title
|
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
src/hotspot/share/prims/jvm.cpp
Outdated
| @@ -2955,9 +2955,10 @@ JVM_ENTRY(void, JVM_StartThread(JNIEnv* env, jobject jthread)) | |||
| // We must release the Threads_lock before we can post a jvmti event | |||
| // in Thread::start. | |||
| { | |||
| MutexLocker throttle_ml(UseThreadsLockThrottleLock ? ThreadsLockThrottle_lock : NULL); | |||
There was a problem hiding this comment.
Should be nullptr, right?
|
|
|
/approval request I'd like to backport this fix to eliminate the performance penalty measured in large thread pools. Some users find this as a blocker for transitioning from JDK8. |
|
@snazarkin |
|
/approval request I'd like to backport this fix to eliminate the performance penalty measured in large thread pools. Some users find this as a blocker for transitioning from JDK8. Revived by Paul Hohensee and Oli Gillespie(original author) |
|
@snazarkin |
|
@snazarkin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
@snazarkin This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the |
I'd like to backport this fix to fix the issue with starting a lot of threads in a burst. Some users found this to be a barrier to migrating from JDK8.
The backport is not clean as required to adjust
globals.hppand replaceConditionalMutexLockerwith classicMutexLocker. Original fix and discussion are hereTested with
tier1and reproducers from JDK-8340547, JDK-8307970Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1365/head:pull/1365$ git checkout pull/1365Update a local copy of the PR:
$ git checkout pull/1365$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1365/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1365View PR using the GUI difftool:
$ git pr show -t 1365Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1365.diff
Using Webrev
Link to Webrev Comment